From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287Ab1FSJ7b (ORCPT ); Sun, 19 Jun 2011 05:59:31 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:60282 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752369Ab1FSJ71 (ORCPT ); Sun, 19 Jun 2011 05:59:27 -0400 Date: Sun, 19 Jun 2011 11:01:41 +0100 From: Alan Cox To: Arnd Bergmann Cc: Wim Van Sebroeck , LKML , Linux Watchdog Mailing List Subject: Re: [PATCH 9/10 v2] Generic Watchdog Timer Driver Message-ID: <20110619110141.1ac221f1@lxorguk.ukuu.org.uk> In-Reply-To: <201106182117.49026.arnd@arndb.de> References: <20110618172727.GJ3441@infomag.iguana.be> <201106182117.49026.arnd@arndb.de> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hmm, I'm not sure about this one. It does make the conversion > of existing drivers easier but doesn't encourage doing a good > job there. It's not ultimately about conversion. A lot of watchdogs have interfaces that are not quite generic, extra requirements and custom interfaces. The ioctl interface is needed for that, not for conversions. Alan