From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358Ab1FSPbQ (ORCPT ); Sun, 19 Jun 2011 11:31:16 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:59556 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137Ab1FSPbO (ORCPT ); Sun, 19 Jun 2011 11:31:14 -0400 Date: Sun, 19 Jun 2011 11:31:10 -0400 From: Christoph Hellwig To: Wu Fengguang Cc: "linux-fsdevel@vger.kernel.org" , Jan Kara , Dave Chinner , Christoph Hellwig , Andrew Morton , LKML Subject: Re: [PATCH 2/7] writeback: add parameters to __bdi_update_bandwidth() Message-ID: <20110619153110.GA20424@infradead.org> References: <20110619150108.691351746@intel.com> <20110619150510.130768812@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110619150510.130768812@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 19, 2011 at 11:01:10PM +0800, Wu Fengguang wrote: > The added parameters will be used by the next patch and more future patches. > > It's separated out for easier review, and will be merged either with the > next patch or with the previous write bandwidth patch in future posts. I don't think adding parameters separately from the code using it is useful. Please fold this into the later patches.