From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: 37573e8c (cgroup fix) causing implicit declaration of function 'node_start_pfn'
Date: Sun, 19 Jun 2011 19:39:55 +0100 [thread overview]
Message-ID: <20110619183955.GH2031@gallifrey> (raw)
In-Reply-To: <20110619104744.9cd631c1.rdunlap@xenotime.net>
* Randy Dunlap (rdunlap@xenotime.net) wrote:
> On Sun, 19 Jun 2011 16:12:14 +0100 Dr. David Alan Gilbert wrote:
>
> > Hi,
> > The current git head is failing to build for me with:
> >
> > mm/page_cgroup.c: In function 'page_cgroup_init':
> > mm/page_cgroup.c:308:3: error: implicit declaration of function 'node_start_pfn'
> > mm/page_cgroup.c:309:3: error: implicit declaration of function 'node_end_pfn'
> >
> > this is for a very basic 32bit x86 build, and it looks like
> > include/asm/mmzone_32.h only defines node_start_pfn and node_end_pfn on
> > CONFIG_DISCONTIGMEM - which I have off.
> >
> > The use of node_start_pfn seems to be from
> >
> > commit 37573e8c718277103f61f03741bdc5606d31b07e
> > Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Date: Wed Jun 15 15:08:42 2011 -0700
> >
> > memcg: fix init_page_cgroup nid with sparsemem
>
> Please see if http://marc.info/?l=linux-kernel&m=130827204306775&w=2
> fixes it for you.
Yes it does (build tested only); thank you for the pointer.
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2011-06-19 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 15:12 Dr. David Alan Gilbert
2011-06-19 17:47 ` Randy Dunlap
2011-06-19 18:39 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619183955.GH2031@gallifrey \
--to=dave@treblig.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®