From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: James Hogan <james@albanarts.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
Date: Tue, 21 Jun 2011 12:17:25 +0200 [thread overview]
Message-ID: <20110621101725.GA670@rere.qmqm.pl> (raw)
In-Reply-To: <BANLkTikMc1WfJMJ2NeBr1E62dGjCj1Cd_w@mail.gmail.com>
On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
> the CONFIG_ before it when used by the preprocessor.
>
> Signed-off-by: James Hogan <james@albanarts.com>
> ---
> drivers/misc/cb710/sgbuf2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
> index d019746..2a40d0e 100644
> --- a/drivers/misc/cb710/sgbuf2.c
> +++ b/drivers/misc/cb710/sgbuf2.c
> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
> sg_mapping_iter *miter)
>
> static inline bool needs_unaligned_copy(const void *ptr)
> {
> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> return false;
> #else
> return ((ptr - NULL) & 3) != 0;
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
[Cc: linux-mmc]
next prev parent reply other threads:[~2011-06-21 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 9:55 James Hogan
2011-06-21 10:17 ` Michał Mirosław [this message]
2011-06-21 16:14 ` Chris Ball
2011-06-21 16:40 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621101725.GA670@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=james@albanarts.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®