From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Arun Sharma <asharma@fb.com>,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH 6/6] Blackfin: SMP: convert to common asm-generic/atomic.h
Date: Tue, 21 Jun 2011 16:05:28 -0700 [thread overview]
Message-ID: <20110621160528.7c92cff0.akpm@linux-foundation.org> (raw)
In-Reply-To: <1308347614-402-7-git-send-email-vapier@gentoo.org>
On Fri, 17 Jun 2011 17:53:34 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> Now that common code supports SMP systems, switch our SMP atomic logic
> over to it to avoid code duplication.
There were some rejects on this one, I think because lines 2, 3 and 4
had non-ascii crap in them and because your patch was expecting
inclusions of asm-generic/atomic-long.h and asm-generic/atomic64.h,
which were removed.
I ended up with the below but I don't know if it works.
/*
* Copyright 2004-2011 Analog Devices Inc.
_*
_* Licensed under the GPL-2 or later.
_*/
#ifndef __ARCH_BLACKFIN_ATOMIC__
#define __ARCH_BLACKFIN_ATOMIC__
#ifdef CONFIG_SMP
#include <linux/linkage.h>
asmlinkage int __raw_uncached_fetch_asm(const volatile int *ptr);
asmlinkage int __raw_atomic_update_asm(volatile int *ptr, int value);
asmlinkage int __raw_atomic_clear_asm(volatile int *ptr, int value);
asmlinkage int __raw_atomic_set_asm(volatile int *ptr, int value);
asmlinkage int __raw_atomic_xor_asm(volatile int *ptr, int value);
asmlinkage int __raw_atomic_test_asm(const volatile int *ptr, int value);
#define atomic_read(v) __raw_uncached_fetch_asm(&(v)->counter)
#define atomic_add_return(i, v) __raw_atomic_update_asm(&(v)->counter, i)
#define atomic_sub_return(i, v) __raw_atomic_update_asm(&(v)->counter, -(i))
#define atomic_clear_mask(m, v) __raw_atomic_clear_asm(&(v)->counter, m)
#define atomic_set_mask(m, v) __raw_atomic_set_asm(&(v)->counter, m)
#endif
#include <asm-generic/atomic.h>
#endif
next prev parent reply other threads:[~2011-06-21 23:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 21:53 [PATCH 0/6] Merge Blackfin/SMP atomic.h support into asm-generic/atomic.h Mike Frysinger
2011-06-17 21:53 ` [PATCH 1/6] asm-generic/atomic.h: simplify inc/dec test helpers Mike Frysinger
2011-06-17 21:53 ` [PATCH 2/6] asm-generic/atomic.h: fix type used in atomic_clear_mask Mike Frysinger
2011-06-17 21:53 ` [PATCH 3/6] asm-generic/atomic.h: add atomic_set_mask helper Mike Frysinger
2011-06-17 21:53 ` [PATCH 4/6] asm-generic/atomic.h: allow SMP peeps to leverage this Mike Frysinger
2011-06-17 21:53 ` [PATCH 5/6] Blackfin: SMP: punt unused atomic_test_mask helper Mike Frysinger
2011-06-17 21:53 ` [PATCH 6/6] Blackfin: SMP: convert to common asm-generic/atomic.h Mike Frysinger
2011-06-21 23:05 ` Andrew Morton [this message]
2011-06-21 23:35 ` [uclinux-dist-devel] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621160528.7c92cff0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=asharma@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome