From: Vasiliy Kulikov <segoon@openwall.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
James Morris <jmorris@namei.org>, Ingo Molnar <mingo@elte.hu>,
Namhyung Kim <namhyung@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH] kernel: escape non-ASCII and control characters in printk()
Date: Wed, 22 Jun 2011 23:07:39 +0400 [thread overview]
Message-ID: <20110622190739.GB14351@albatros> (raw)
In-Reply-To: <20110622191022.66135615@lxorguk.ukuu.org.uk>
Hi Alan,
On Wed, Jun 22, 2011 at 19:10 +0100, Alan Cox wrote:
> If that is set you shouldn't be filtering out unicode, just control codes.
OK.
> Minor other nit is that you might want to allow BEL through and you
> certainly want to allow tab through.
In what situation do you think BEL makes sense in kernel log? I cannot
image the situation. Alarms should use KERN_EMERG/KERN_ALERT log level.
> The core code should not be hardcoding policy assumptions about symbol
> sets and ASCII, for an awful lot of consoles today that assumption is
> just plain wrong, for others it makes sense
No problem, I don't insist.
> So with tty maintainer hat on - NAK to the current approach but a good
> idea to do it properly.
The final check should be:
if (iscntrl(c) && (c != '\n') && (c != '\t'))
Any comments against this variant?
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-06-22 19:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 9:53 Vasiliy Kulikov
2011-06-22 15:37 ` Greg KH
2011-06-22 16:13 ` Vasiliy Kulikov
2011-06-23 13:36 ` Matthew Garrett
2011-06-23 21:44 ` Greg KH
2011-07-11 6:37 ` Pavel Machek
2011-06-22 16:38 ` Joe Perches
2011-06-22 16:53 ` Vasiliy Kulikov
2011-06-22 17:14 ` Joe Perches
2011-06-22 17:48 ` Vasiliy Kulikov
2011-06-22 18:10 ` Alan Cox
2011-06-22 19:07 ` Vasiliy Kulikov [this message]
2011-06-23 18:11 ` Geert Uytterhoeven
2011-06-25 20:52 ` [Security] " Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622190739.GB14351@albatros \
--to=segoon@openwall.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®