From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 7/7] serial/8250: make PIO support optional
Date: Tue, 28 Jun 2011 11:05:00 +0100 [thread overview]
Message-ID: <20110628110500.1cf60104@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1309211120-2803-8-git-send-email-arnd@arndb.de>
> This makes the PIO support in the 8250 driver completely
> conditional on CONFIG_HAS_IOPORT so we can remove the bogus
> definitions from all the places that only need them for 8250.
NAK this as last time.
We had a discussion about how to fix this properly. I even posted some
sketched out patches to show how it could be addressed
Shotgunning the code with ifdefs was not that.
Get the port methods out of the core code as was proposed.
next prev parent reply other threads:[~2011-06-28 10:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 21:45 [PATCH 0/7] serial/8250: I/O accessor cleanups Arnd Bergmann
2011-06-27 21:45 ` [PATCH 1/7] serial/8250: remove obsolete RM9000 port type Arnd Bergmann
2011-06-27 21:45 ` [PATCH 2/7] serial/8250: move alchemy I/O handler to platform code Arnd Bergmann
2011-06-28 8:06 ` Manuel Lauss
2011-06-28 11:29 ` Manuel Lauss
2011-06-28 15:36 ` Manuel Lauss
2011-06-28 17:07 ` Arnd Bergmann
2011-06-27 21:45 ` [PATCH 3/7] serial/8250: move UPIO_TSI to powerpc Arnd Bergmann
2011-06-27 23:51 ` David Daney
2011-09-01 6:02 ` Benjamin Herrenschmidt
2011-09-01 8:28 ` Arnd Bergmann
2011-06-27 21:45 ` [PATCH 4/7] serial/8250: move DWAP support to arch/mips Arnd Bergmann
2011-06-27 22:15 ` Jamie Iles
2011-06-28 5:43 ` Arnd Bergmann
2011-06-28 10:06 ` Alan Cox
2011-06-28 10:48 ` Arnd Bergmann
2011-06-27 21:45 ` [PATCH 5/7] serial/8250: remove obsolete and broken PORT_RSA support Arnd Bergmann
2011-06-28 10:11 ` Alan Cox
2011-06-27 21:45 ` [PATCH 6/7] serial/8250: sanitize fourport handling Arnd Bergmann
2011-06-28 10:10 ` Alan Cox
2011-06-28 12:07 ` Arnd Bergmann
2011-06-27 21:45 ` [PATCH 7/7] serial/8250: make PIO support optional Arnd Bergmann
2011-06-28 10:05 ` Alan Cox [this message]
2011-06-28 11:52 ` Arnd Bergmann
2011-06-28 12:22 ` Alan Cox
2011-07-04 16:35 ` Arnd Bergmann
2011-07-04 17:02 ` Alan Cox
2011-07-04 19:27 ` Arnd Bergmann
2011-07-04 19:53 ` Alan Cox
2011-07-04 20:37 ` Arnd Bergmann
2011-07-04 21:55 ` Alan Cox
2011-07-04 21:54 ` Arnd Bergmann
2011-06-28 10:11 ` Alan Cox
2011-06-27 23:57 ` [PATCH 0/7] serial/8250: I/O accessor cleanups David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628110500.1cf60104@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®