From: Felipe Balbi <balbi@ti.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: balbi@ti.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com,
avictor.za@gmail.com
Subject: Re: [PATCH] AT91: add AT91SAM9X5 dummy configuration variable
Date: Tue, 28 Jun 2011 15:26:51 +0300 [thread overview]
Message-ID: <20110628122650.GK2612@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4E09C573.2030607@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 2240 bytes --]
Hi,
On Tue, Jun 28, 2011 at 02:13:39PM +0200, Nicolas Ferre wrote:
> Le 28/06/2011 12:35, Felipe Balbi :
> > On Tue, Jun 28, 2011 at 01:35:27PM +0200, Nicolas Ferre wrote:
> >> Add this Kconfig variable to ease the submission of this chip support.
> >> As this chip/board inclusion is dealayed due to deep consolidation of
> >> arm/mach-at91 sources, we include this dummy configuration variable to allow
> >> submission of SAM9x5 related drivers in other subsystems.
> >
> > Why are the drivers even depending on this ? They should be portable
> > enough. Can you share a few drivers so we have a look ?
>
> Yes sure. The dependence is only on the Kconfig side: I plan to make
> some drivers dependent on this configuration variable.
> The goal is to submit the final driver addition without having to send
> again a correction to the Kconfig after the chip/board support is merged.
my point is that the drivers shouldn't need that ;-) Are the controllers
Atmel's specific or are you guys sourcing from somewhere else ?
> This will ease the submission process at the cost of a two lines dummy
> patch and will remove interdependence between subsystem trees: it worth
> it, is not it?
if you remove any architecture dependency from the driver, why do you
even need these two lines ? ;-)
> > IMHO, the whole idea of the consolidation is beyond arch/arm, drivers
> > should be affected too.
>
> Yes sure, I also understood like this.
> I will not spread ARCH_AT91SAM9X5 ifdef in driver code...
yet you will prevent the driver from being easily used by other
architectures. What will happen is that a certain amount of:
depends on (ARCH_AT91SAM9X5 || ARCH_FOO || ARCH_BAR || ARCH_BAZ)
will continue to proliferate.
Here are a few questions:
i) The drivers you're willing to send, are those for Atmel's IPs or are
the IPs sourced from some other company ?
ii) Even if they are Atmel-specific, do you see the possibility of Atmel
licensing them ?
iii) Does your driver current depend on asm/ or mach/ headers ?
iv) Is there a generic header which you could use instead of asm/ mach/ ?
If you could share the driver, it would be easier to review on that one.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-06-28 12:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 11:35 Nicolas Ferre
2011-06-28 10:35 ` Felipe Balbi
2011-06-28 12:13 ` Nicolas Ferre
2011-06-28 12:26 ` Felipe Balbi [this message]
2011-06-28 16:02 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-29 9:30 ` Felipe Balbi
2011-06-29 15:24 ` Nicolas Ferre
2011-06-29 15:39 ` Felipe Balbi
2011-07-02 9:49 ` Arnd Bergmann
2011-07-04 9:23 ` Nicolas Ferre
2011-07-05 5:32 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-05 11:25 ` Arnd Bergmann
2011-06-28 16:03 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628122650.GK2612@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®