mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Joerg Roedel <joro@8bytes.org>,
	Joerg Roedel <joerg.roedel@amd.com>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Avi Kiviti <avi@redhat.com>
Subject: Re: [PATCH 0/5] perf support for amd guest/host-only bits v2
Date: Wed, 29 Jun 2011 22:05:47 +1000	[thread overview]
Message-ID: <20110629120547.GS25406@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <1309338174.6701.929.camel@twins>

On Wed, Jun 29, 2011 at 11:02:54AM +0200, Peter Zijlstra wrote:
> On Tue, 2011-06-28 at 18:10 +0200, Joerg Roedel wrote:
> > On Fri, Jun 17, 2011 at 03:37:29PM +0200, Joerg Roedel wrote:
> > > this is the second version of the patch-set to support the AMD
> > > guest-/host only bits in the performance counter MSRs. Due to lack of
> > > time I havn't looked into emulating support for this feature on Intel or
> > > other architectures, but the other comments should be worked in. The
> > > changes to v1 include:
> > > 
> > > 	* Rebased patches to v3.0-rc3
> > > 	* Allow exclude_guest and exclude_host set at the same time
> > > 	* Reworked event-parse logic for the new exclude-bits
> > > 	* Only count guest-events per default from perf-kvm
> > 
> > Hi Peter, Ingo,
> > 
> > have you had a chance to look at this patch-set? Are any changes
> > required?
> 
> I would feel a lot more comfortable by having it implemented on all of
> x86 as well as at least one !x86 platform. Avi graciously volunteered
> for the Intel bits.  
> 
> Paulus, I hear from benh that you're also responsible for the ppc-kvm
> bits, could you possibly find some time to implement this feature for
> ppc?

I'll have a look at it, but I don't know how quickly I'll be able to
produce a patch.

We have two styles of KVM on PowerPC (at least as far as server
processors are concerned), one where the guest runs entirely in
usermode and the privileged facilities are emulated, and another that
uses hypervisor mode in the host and can allow the guest to use
supervisor mode.  In the latter case, the PMU is considered a guest
resource, that is, the hardware allows the guest to manipulate the PMU
directly, and PMU interrupts go directly to the guest.  In that mode
it's not really possible to count or profile guest activity from the
host.  There are some hypervisor-only counters in the PMU but they
have limited event selection compared to the counters available to the
guest.

Paul.


      parent reply	other threads:[~2011-06-29 12:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 13:37 Joerg Roedel
2011-06-17 13:37 ` [PATCH 1/5] perf, core: Introduce attrs to count in either host or guest mode Joerg Roedel
2011-06-17 13:37 ` [PATCH 2/5] perf, amd: Use GO/HO bits in perf-ctr Joerg Roedel
2011-06-17 13:37 ` [PATCH 3/5] perf, tools: Add support for guest/host-only profiling Joerg Roedel
2011-06-17 13:37 ` [PATCH 4/5] perf, tools: Fix copy&paste error in perf-kvm option description Joerg Roedel
2011-06-17 13:37 ` [PATCH 5/5] perf, tools: Do guest-only counting in perf-kvm by default Joerg Roedel
2011-06-19  9:01 ` [PATCH 0/5] perf support for amd guest/host-only bits v2 Avi Kivity
2011-06-28 16:10 ` Joerg Roedel
2011-06-29  9:02   ` Peter Zijlstra
2011-06-29  9:27     ` Avi Kivity
2011-06-29  9:48       ` Joerg Roedel
2011-06-29  9:36     ` Roedel, Joerg
2011-06-29 12:05     ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110629120547.GS25406@bloggs.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=avi@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®