From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754875Ab1F2MUh (ORCPT ); Wed, 29 Jun 2011 08:20:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50815 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222Ab1F2MUf (ORCPT ); Wed, 29 Jun 2011 08:20:35 -0400 Date: Wed, 29 Jun 2011 14:20:34 +0200 From: Michal Hocko To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "bsingharora@gmail.com" , Ying Han Subject: Re: [PATCH] [Cleanup] memcg: export memory cgroup's swappiness v2 Message-ID: <20110629122034.GA24262@tiehlicka.suse.cz> References: <20110629190325.28aa2dc6.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110629190325.28aa2dc6.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 29-06-11 19:03:25, KAMEZAWA Hiroyuki wrote: > This is onto 3 patches I posted yesterday. > I'm sorry I once got Acks in v1 but refleshed totally. > == > From fda72071ee473be1caee163920da0f5c397c95e8 Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki > Date: Wed, 29 Jun 2011 18:24:49 +0900 > Subject: [PATCH] export memory cgroup's swappines > > Each memory cgroup has 'swappiness' value and it can be accessed by > get_swappiness(memcg). The major user is try_to_free_mem_cgroup_pages() > and swappiness is passed by argument. It's propagated by scan_control. > > get_swappiness is static function but some planned updates will need to > get swappiness from files other than memcontrol.c > This patch exports get_swappiness() as mem_cgroup_swappiness(). > By this, we can remove the argument of swapiness from try_to_free... > and drop swappiness from scan_control. only memcg uses it. > > Signed-off-by: KAMEZAWA Hiroyuki Reviewed-by: Michal Hocko > > Changelog: > - drop swappiness from scan_control Yes, this is even better. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic