Re: Build regressions/improvements in v3.0-rc5 (arch/cris)

[Randy Dunlap <rdunlap@xenotime.net>]

On Wed, 29 Jun 2011 10:13:17 +0200 (CEST) Geert Uytterhoeven wrote:

> *** ERRORS ***
> 
> 698 regressions:

>   + net/mac80211/led.c: error: 'struct led_classdev' has no member named 'trig_list':  => 213, 277
>   + net/mac80211/led.c: error: dereferencing pointer to incomplete type:  => 73, 91, 100, 82
>   + net/mac80211/led.c: error: implicit declaration of function 'led_trigger_register':  => 74
>   + net/mac80211/led.c: error: implicit declaration of function 'led_trigger_unregister':  => 118
>   + net/mac80211/led.c: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' :  => 98, 71, 89, 80


I think that this is what Andrew would call a cockup, or at least I would.

These errors shouldn't be possible since net/mac80211/Kconfig says:

config MAC80211_LEDS
	bool "Enable LED triggers"
	depends on MAC80211
	depends on LEDS_CLASS
	select LEDS_TRIGGERS



Preferably arch/cris/Kconfig would source drivers/Kconfig instead of sourcing
individual drivers/foobar/Kconfig.

Second option is for arch/cris/Kconfig to source drivers/leds/Kconfig
unless there is some reason to avoid this (?).

Or we should just prevent this particular driver from being built,
but that's the least desirable choice here.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***