From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org
Subject: Re: [PATCH v3] Add ARM cpu topology definition
Date: Thu, 30 Jun 2011 11:34:32 +0100 [thread overview]
Message-ID: <20110630103432.GV21898@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1308940724-2099-1-git-send-email-vincent.guittot@linaro.org>
On Fri, Jun 24, 2011 at 08:38:44PM +0200, Vincent Guittot wrote:
> + printk(KERN_INFO "cpu %u : thread %d cpu %d, socket %d, mpidr %x\n",
> + cpuid, cpu_topology[cpuid].thread_id,
> + cpu_topology[cpuid].core_id,
> + cpu_topology[cpuid].socket_id, mpidr);
> +
> +}
Please remove that empty blank line before the closing brace.
Also...
cpu 0 : thread -1 cpu 0, socket 0, mpidr 80000000
Calibrating local timer... 199.99MHz.
hw perfevents: enabled with ARMv7 Cortex-A9 PMU driver, 7 counters available
CPU1: Booted secondary processor
cpu 1 : thread -1 cpu 1, socket 0, mpidr 80000001
CPU2: Booted secondary processor
cpu 2 : thread -1 cpu 2, socket 0, mpidr 80000002
CPU3: Booted secondary processor
cpu 3 : thread -1 cpu 3, socket 0, mpidr 80000003
Brought up 4 CPUs
It'd be better to have some consistency there - please change from
"cpu %u :" to "CPU%u:".
next prev parent reply other threads:[~2011-06-30 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 18:38 Vincent Guittot
2011-06-30 10:34 ` Russell King - ARM Linux [this message]
2011-06-30 12:49 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630103432.GV21898@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®