From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Éric Piel" <e.a.b.piel@tudelft.nl>, "Greg KH" <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: Regression 3.0-rc5+ : khubd blocked
Date: Fri, 1 Jul 2011 13:08:00 -0700 [thread overview]
Message-ID: <20110701200800.GB17865@xanatos> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1107011317250.1988-100000@iolanthe.rowland.org>
On Fri, Jul 01, 2011 at 01:19:23PM -0400, Alan Stern wrote:
> On Fri, 1 Jul 2011, [ISO-8859-1] ?ric Piel wrote:
>
> > Sorry, but from a quick look, it seems to not fix the bug.
> >
> > I'll try further on Monday.
>
> Do you get a similar message from the task watchdog? The patch should
> have caused usb_set_interface() to return early, without trying to
> acquire the mutex that caused the problem before.
I've been able to reproduce this bug with linus/master. When I apply
your patch (or at least change the code to match your patch, since I
don't have those top-level directories), I can successfully unplug and
replug in a hub with a keyboard and mouse attached to it, with no hangs.
So I'm not sure why it isn't working for Éric.
One further complication of the original patch is that when the xHCI
driver is unloaded, usb_disable_device is called for devices under the
USB 2.0 split rootub after the USB 3.0 roothub has been unregistered and
the xHCI host is halted. The configure endpoint code doesn't actually
check if the hardware is running before submitting commands, so it takes
about 30 seconds for the command for each device to timeout. So that
needs to be fixed as well.
Do you mind if I just take your patch and make a proper fix out of it?
Sarah Sharp
next prev parent reply other threads:[~2011-07-01 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 16:20 Éric Piel
2011-07-01 17:19 ` Alan Stern
2011-07-01 20:08 ` Sarah Sharp [this message]
2011-07-01 20:40 ` Alan Stern
2011-07-01 20:53 ` Sarah Sharp
2011-07-01 22:05 ` Éric Piel
-- strict thread matches above, loose matches on Subject: below --
2011-07-01 12:45 Éric Piel
2011-07-01 13:29 ` Greg KH
2011-07-01 15:21 ` Alan Stern
2011-07-01 15:41 ` Éric Piel
2011-07-01 16:12 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701200800.GB17865@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=e.a.b.piel@tudelft.nl \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®