From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: [patch 08/11] powerpc/irqs: Do not trace arch_local_{*,irq_*} functions
Date: Fri, 01 Jul 2011 23:04:43 -0400 [thread overview]
Message-ID: <20110702033854.145799127@goodmis.org> (raw)
In-Reply-To: <20110702030435.308336775@goodmis.org>
[-- Attachment #1: 0008-powerpc-irqs-Do-not-trace-arch_local_-irq_-functions.patch --]
[-- Type: text/plain, Size: 3907 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
Do not trace arch_local_save_flags(), arch_local_irq_*() and friends.
Although they are marked inline, gcc may still make a function out of
them and add it to the pool of functions that are traced by the function
tracer. This can cause undesirable results (kernel panic, triple faults,
etc).
Add the notrace notation to prevent them from ever being traced.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/powerpc/include/asm/hw_irq.h | 26 +++++++++++++-------------
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index bb712c9..c8e651f 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -16,7 +16,7 @@ extern void timer_interrupt(struct pt_regs *);
#ifdef CONFIG_PPC64
#include <asm/paca.h>
-static inline unsigned long arch_local_save_flags(void)
+static inline notrace unsigned long arch_local_save_flags(void)
{
unsigned long flags;
@@ -28,7 +28,7 @@ static inline unsigned long arch_local_save_flags(void)
return flags;
}
-static inline unsigned long arch_local_irq_disable(void)
+static inline notrace unsigned long arch_local_irq_disable(void)
{
unsigned long flags, zero;
@@ -44,22 +44,22 @@ static inline unsigned long arch_local_irq_disable(void)
extern void arch_local_irq_restore(unsigned long);
extern void iseries_handle_interrupts(void);
-static inline void arch_local_irq_enable(void)
+static inline notrace void arch_local_irq_enable(void)
{
arch_local_irq_restore(1);
}
-static inline unsigned long arch_local_irq_save(void)
+static inline notrace unsigned long arch_local_irq_save(void)
{
return arch_local_irq_disable();
}
-static inline bool arch_irqs_disabled_flags(unsigned long flags)
+static inline notrace bool arch_irqs_disabled_flags(unsigned long flags)
{
return flags == 0;
}
-static inline bool arch_irqs_disabled(void)
+static inline notrace bool arch_irqs_disabled(void)
{
return arch_irqs_disabled_flags(arch_local_save_flags());
}
@@ -83,12 +83,12 @@ static inline bool arch_irqs_disabled(void)
#define SET_MSR_EE(x) mtmsr(x)
-static inline unsigned long arch_local_save_flags(void)
+static inline notrace unsigned long arch_local_save_flags(void)
{
return mfmsr();
}
-static inline void arch_local_irq_restore(unsigned long flags)
+static inline notrace void arch_local_irq_restore(unsigned long flags)
{
#if defined(CONFIG_BOOKE)
asm volatile("wrtee %0" : : "r" (flags) : "memory");
@@ -97,7 +97,7 @@ static inline void arch_local_irq_restore(unsigned long flags)
#endif
}
-static inline unsigned long arch_local_irq_save(void)
+static inline notrace unsigned long arch_local_irq_save(void)
{
unsigned long flags = arch_local_save_flags();
#ifdef CONFIG_BOOKE
@@ -108,7 +108,7 @@ static inline unsigned long arch_local_irq_save(void)
return flags;
}
-static inline void arch_local_irq_disable(void)
+static inline notrace void arch_local_irq_disable(void)
{
#ifdef CONFIG_BOOKE
asm volatile("wrteei 0" : : : "memory");
@@ -117,7 +117,7 @@ static inline void arch_local_irq_disable(void)
#endif
}
-static inline void arch_local_irq_enable(void)
+static inline notrace void arch_local_irq_enable(void)
{
#ifdef CONFIG_BOOKE
asm volatile("wrteei 1" : : : "memory");
@@ -127,12 +127,12 @@ static inline void arch_local_irq_enable(void)
#endif
}
-static inline bool arch_irqs_disabled_flags(unsigned long flags)
+static inline notrace bool arch_irqs_disabled_flags(unsigned long flags)
{
return (flags & MSR_EE) == 0;
}
-static inline bool arch_irqs_disabled(void)
+static inline notrace bool arch_irqs_disabled(void)
{
return arch_irqs_disabled_flags(arch_local_save_flags());
}
--
1.7.5.4
next prev parent reply other threads:[~2011-07-02 3:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110702030435.308336775@goodmis.org>
2011-07-02 3:04 ` [patch 01/11] x86/irqs: " Steven Rostedt
2011-07-07 0:51 ` Steven Rostedt
2011-07-07 21:43 ` [tip:perf/core] tracing, x86/irq: Do not trace arch_local_{*,irq_*}() functions tip-bot for Steven Rostedt
2011-07-02 3:04 ` [patch 02/11] arm/irqs: Do not trace arch_local_{*,irq_*} functions Steven Rostedt
2011-07-02 3:04 ` [patch 03/11] blackfin/irqs: " Steven Rostedt
2011-07-02 6:50 ` Mike Frysinger
2011-07-02 16:11 ` Steven Rostedt
2011-07-02 16:39 ` Mike Frysinger
2011-07-02 16:40 ` Mike Frysinger
2011-07-05 12:51 ` Steven Rostedt
2011-07-05 16:20 ` Mike Frysinger
2011-07-05 19:07 ` Mike Frysinger
2011-07-05 19:13 ` Steven Rostedt
2011-07-05 19:25 ` Mike Frysinger
2011-07-02 3:04 ` [patch 04/11] ia64/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 05/11] microblaze/irqs: " Steven Rostedt
2011-07-05 10:43 ` Michal Simek
2011-07-05 12:49 ` Steven Rostedt
2011-07-02 3:04 ` [patch 06/11] mips/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 07/11] parisc/irqs: " Steven Rostedt
2011-07-02 3:04 ` Steven Rostedt [this message]
2011-07-02 3:04 ` [patch 09/11] s390/irqs: " Steven Rostedt
2011-07-04 8:10 ` Martin Schwidefsky
2011-07-05 12:49 ` Steven Rostedt
2011-07-02 3:04 ` [patch 10/11] sh/unicore32/irqs: " Steven Rostedt
2011-07-04 1:56 ` Guan Xuetao
2011-07-05 12:50 ` Steven Rostedt
2011-07-11 3:34 ` Paul Mundt
2011-07-13 1:36 ` Steven Rostedt
2011-07-02 3:04 ` [patch 11/11] sparc/irqs: " Steven Rostedt
2011-07-02 4:11 ` David Miller
2011-07-05 12:49 ` Steven Rostedt
2011-07-06 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110702033854.145799127@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome