From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851Ab1GCGte (ORCPT ); Sun, 3 Jul 2011 02:49:34 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:50782 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505Ab1GCGtb (ORCPT ); Sun, 3 Jul 2011 02:49:31 -0400 From: "Rafael J. Wysocki" To: "H. Peter Anvin" Subject: Re: [PATCH 1/2] merge 32 and 64 realmode wakeup code Date: Sun, 3 Jul 2011 08:50:32 +0200 User-Agent: KMail/1.13.6 (Linux/3.0.0-rc5+; KDE/4.6.0; x86_64; ; ) Cc: Matthieu CASTET , Linux Kernel list , linux-acpi@vger.kernel.org, x86@kernel.org References: <1309628621-23107-1-git-send-email-castet.matthieu@free.fr> <4E0F9C3F.8020907@zytor.com> In-Reply-To: <4E0F9C3F.8020907@zytor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201107030850.32457.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, July 03, 2011, H. Peter Anvin wrote: > On 07/02/2011 10:43 AM, Matthieu CASTET wrote: > > - this mean less ifdef in code > > - we could remove now unused field in wakeup_header (pmode_*) > > > > Signed-off-by: Matthieu CASTET > > --- > > arch/x86/kernel/acpi/realmode/wakeup.S | 26 -------------------------- > > arch/x86/kernel/acpi/sleep.c | 27 ++++++++++----------------- > > arch/x86/kernel/trampoline_32.S | 4 ---- > > 3 files changed, 10 insertions(+), 47 deletions(-) > > > > Looks great to me. Rafael? I don't have any immediate complaints. Please feel free to add my ACK to the patches. Thanks, Rafael