From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org,
Thomas Hellstrom <thomas@tungstengraphics.com>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] gma500: fix compiler warnings and format string
Date: Sun, 3 Jul 2011 13:37:32 +0100 [thread overview]
Message-ID: <20110703133732.4e2ed436@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.1107030914100.16316@swampdragon.chaosbits.net>
On Sun, 3 Jul 2011 09:16:13 +0200 (CEST)
Jesper Juhl <jj@chaosbits.net> wrote:
> This patch fixes these compiler warnings:
>
> CC drivers/staging/gma500/psb_gtt.o
> drivers/staging/gma500/psb_gtt.c: In function ‘psb_gtt_insert’:
> drivers/staging/gma500/psb_gtt.c:81:33: warning: unused variable ‘dev_priv’ [-Wunused-variable]
> drivers/staging/gma500/psb_gtt.c: In function ‘psb_gtt_pin’:
> drivers/staging/gma500/psb_gtt.c:237:2: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized]
>
> It also fixes up the format string used in DRM_DEBUG() in
> drivers/staging/gma500/psb_gtt.c:psb_gtt_init() - the string required
> two arguments but only one was supplied.
>
> While reading through the file I also deleted what trailing whitespace
> I encountered.
Unfortunately this file doesn't even exist in the working tree any more.
Please wait until Greg has taken the patch set I sent him to replace the
one that didn't apply, and the patch series after that (and quite
possibly the one after that assuming I can get Cedartrail to work next
week).
Alan
next prev parent reply other threads:[~2011-07-03 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 7:16 Jesper Juhl
2011-07-03 12:37 ` Alan Cox [this message]
2011-07-04 9:10 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110703133732.4e2ed436@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@tungstengraphics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®