mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: bcm: sort: kill handrolled bubblesort
Date: Sun, 3 Jul 2011 22:14:04 +0300	[thread overview]
Message-ID: <20110703191404.GL2544@shale.localdomain> (raw)
In-Reply-To: <1309667900-2225-1-git-send-email-chrisf@ijw.co.nz>

On Sun, Jul 03, 2011 at 04:38:20PM +1200, Chris Forbes wrote:
> Replaced the handrolled bubblesort with the kernel's sort() function.
> Makes things considerably smaller & clearer.
> 

Did you test this?  It's Ok to not test it if you can't but the
changelog should probably say one way or the other.

regards,
dan carpenter

  reply	other threads:[~2011-07-03 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-03  4:38 Chris Forbes
2011-07-03 19:14 ` Dan Carpenter [this message]
2011-07-03 20:06   ` Chris Forbes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110703191404.GL2544@shale.localdomain \
    --to=error27@gmail.com \
    --cc=chrisf@ijw.co.nz \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®