From: Kees Cook <kees.cook@canonical.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Brian Gerst <brgerst@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: add missing verify_cpu to 32bit wakeup
Date: Sun, 3 Jul 2011 12:15:22 -0700 [thread overview]
Message-ID: <20110703191522.GX32221@outflux.net> (raw)
In-Reply-To: <20110703121549.GA21127@elf.ucw.cz>
Hi Pavel,
On Sun, Jul 03, 2011 at 02:15:49PM +0200, Pavel Machek wrote:
> > Some BIOSes will reset the Intel XD_DISABLE MSR bit when resuming from S3,
> > which can interact poorly with ebba638ae723d8a8fc2f7abce5ec18b688b791d7.
> > In 32bit PAE mode, this can lead to a fault when EFER is restored by
> > the kernel wakeup routines, due to it setting the NX bit for a CPU
> > that (thanks to the BIOS reset) now incorrectly thinks it lacks the NX
> > feature. 64bit wakeup already handled this through its common call path
> > that would hit verify_cpu(). 32bit has a separate path for restoring
> > CPU state on S3 wakeup, and needed to call verify_cpu() to handle this
> > situation.
> >
> > Signed-off-by: Kees Cook <kees.cook@canonical.com>
> > Cc: stable@kernel.org
>
> Looks ok to me, but I'm not sure it is stable material.
Well, I figured anything that shipped with
ebba638ae723d8a8fc2f7abce5ec18b688b791d7 should get it, since it is
a regression in the 32bit PAE with BIOS-disabled NX corner-case.
-Kees
--
Kees Cook
Ubuntu Security Team
next prev parent reply other threads:[~2011-07-03 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 21:19 Kees Cook
2011-07-01 21:26 ` H. Peter Anvin
2011-07-01 22:36 ` Kees Cook
2011-07-01 23:07 ` H. Peter Anvin
2011-07-03 12:15 ` Pavel Machek
2011-07-03 19:15 ` Kees Cook [this message]
2011-07-03 21:25 ` H. Peter Anvin
2011-07-03 21:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110703191522.GX32221@outflux.net \
--to=kees.cook@canonical.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®