From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952Ab1GDJLR (ORCPT ); Mon, 4 Jul 2011 05:11:17 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:60890 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583Ab1GDJLP (ORCPT ); Mon, 4 Jul 2011 05:11:15 -0400 Date: Mon, 4 Jul 2011 12:10:16 +0300 From: Dan Carpenter To: Jonathan Cameron Cc: Chris Forbes , devel@driverdev.osuosl.org, "linux-iio@vger.kernel.org" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use Message-ID: <20110704091016.GM2544@shale.localdomain> References: <1309657621-21711-1-git-send-email-chrisf@ijw.co.nz> <4E118157.3020906@cam.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E118157.3020906@cam.ac.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2011 at 10:01:11AM +0100, Jonathan Cameron wrote: > On 07/03/11 02:47, Chris Forbes wrote: > > Fixed an uninitialized variable access. In the first two error paths in > > max1363_probe(), 'st' is not yet initialized, but its 'reg' member is > > accessed anyway. This would most likely crash. > Good spot. Please tech TODO files for staging patches. In this case it would > have given you the mailing list, now cc'd. It would better to add an entry to MAINTAINERS so that ./scripts/get_maintainer.pl gave the right lists. regards, dan carpenter