From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775Ab1GDTvE (ORCPT ); Mon, 4 Jul 2011 15:51:04 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55076 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751585Ab1GDTvC (ORCPT ); Mon, 4 Jul 2011 15:51:02 -0400 Date: Mon, 4 Jul 2011 20:53:36 +0100 From: Alan Cox To: Arnd Bergmann Cc: "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 7/7] serial/8250: make PIO support optional Message-ID: <20110704205336.09547e1f@lxorguk.ukuu.org.uk> In-Reply-To: <201107042127.31649.arnd@arndb.de> References: <1309211120-2803-1-git-send-email-arnd@arndb.de> <201107041835.22660.arnd@arndb.de> <20110704180216.4dc9c79d@lxorguk.ukuu.org.uk> <201107042127.31649.arnd@arndb.de> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ok, makes sense. If I split this out to the ISA driver, I would > probably also disallow changing io_type, as ISA 8250 ports are > all based on PIO mode. Alas not, they also come in MMIO form now and then, not often but just enough to be annoyingly unignorable. However the ISA driver can handle that 'in-house' and I've never seen anything but PIO or simple MMIO. Alan