From: David Miller <davem@davemloft.net>
To: loke.chetan@gmail.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, joe@perches.com,
bhutchings@solarflare.com, shemminger@vyatta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next af-packet 1/2] Enhance af-packet to provide (near zero)lossless packet capture functionality.
Date: Tue, 05 Jul 2011 08:01:23 -0700 (PDT) [thread overview]
Message-ID: <20110705.080123.2174577714045488116.davem@davemloft.net> (raw)
In-Reply-To: <CAAsGZS5vvmb_qX+cG507=hU_+kwnowEEojXGNMt5ShEZ9+ZeAA@mail.gmail.com>
From: chetan loke <loke.chetan@gmail.com>
Date: Tue, 5 Jul 2011 10:53:26 -0400
>> Next, having this overlay thing is entirely pointless. Just refer to
>
> It is useful.
> Also, future versions of the block-descriptor can append a new field.
> When that happens,
> none of the code needs to worry about the version etc for the unchanged fields.
That issue only exists because you haven't defined a common header
struct that the current, and all future, block descriptor variants can
include at the start of their definitions.
I still contend that all of these abstractions are too much and
unnecessary.
Use real data structures, not opaque "offset+size" poking into the
descriptors.
next prev parent reply other threads:[~2011-07-05 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 2:10 [PATCH v2 net-next af-packet 0/2] " Chetan Loke
2011-06-22 2:10 ` [PATCH v2 net-next af-packet 1/2] " Chetan Loke
2011-07-01 22:36 ` David Miller
2011-07-05 14:53 ` chetan loke
2011-07-05 15:01 ` David Miller [this message]
2011-07-06 21:45 ` chetan loke
2011-07-07 7:13 ` David Miller
2011-07-07 13:04 ` chetan loke
2011-07-07 13:11 ` David Miller
2011-06-22 2:10 ` [PATCH v2 net-next af-packet 2/2] " Chetan Loke
2011-06-22 3:02 ` [PATCH v2 net-next af-packet 0/2] " chetan loke
2011-06-22 8:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705.080123.2174577714045488116.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loke.chetan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®