From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Warren <swarren@nvidia.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] spi/tegra: Use engineering names in DT compatible property
Date: Tue, 5 Jul 2011 23:38:59 -0600 [thread overview]
Message-ID: <20110706053859.GD9978@ponder.secretlab.ca> (raw)
In-Reply-To: <1309897082-22695-1-git-send-email-swarren@nvidia.com>
On Tue, Jul 05, 2011 at 02:18:02PM -0600, Stephen Warren wrote:
> Engineering names are more stable than marketing names. Hence, use them
> for Device Tree compatible properties instead.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Grant, this is against devicetree/arm, and also makes sense for
> devicetree/test.
Applied to spi/next, thanks.
g.
>
> .../devicetree/bindings/spi/spi_nvidia.txt | 2 +-
> drivers/spi/spi_tegra.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi_nvidia.txt b/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> index bde450b..6b9e518 100644
> --- a/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> +++ b/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> @@ -1,5 +1,5 @@
> NVIDIA Tegra 2 SPI device
>
> Required properties:
> -- compatible : should be "nvidia,tegra250-spi".
> +- compatible : should be "nvidia,tegra20-spi".
> - gpios : should specify GPIOs used for chipselect.
> diff --git a/drivers/spi/spi_tegra.c b/drivers/spi/spi_tegra.c
> index 1e7de98..b0e3586 100644
> --- a/drivers/spi/spi_tegra.c
> +++ b/drivers/spi/spi_tegra.c
> @@ -598,7 +598,7 @@ MODULE_ALIAS("platform:spi_tegra");
>
> #ifdef CONFIG_OF
> static struct of_device_id spi_tegra_of_match_table[] __devinitdata = {
> - { .compatible = "nvidia,tegra250-spi", },
> + { .compatible = "nvidia,tegra20-spi", },
> {}
> };
> MODULE_DEVICE_TABLE(of, spi_tegra_of_match_table);
> --
> 1.7.0.4
>
prev parent reply other threads:[~2011-07-06 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 20:18 Stephen Warren
2011-07-06 5:38 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706053859.GD9978@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®