mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Warren <swarren@nvidia.com>
Cc: ben-linux@fluff.org, khali@linux-fr.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] i2c: tegra: Use engineering names in DT compatible property
Date: Tue, 5 Jul 2011 23:39:41 -0600	[thread overview]
Message-ID: <20110706053941.GE9978@ponder.secretlab.ca> (raw)
In-Reply-To: <1309897306-22953-1-git-send-email-swarren@nvidia.com>

On Tue, Jul 05, 2011 at 02:21:46PM -0600, Stephen Warren wrote:
> Engineering names are more stable than marketing names. Hence, use them
> for Device Tree compatible properties instead.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Grant, this is against devicetree/arm and also makes sense for
> devicetree/test.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

Ben is the one to pick up this patch.

g.

> 
>  drivers/i2c/busses/i2c-tegra.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 8914bd1..99b1b6d 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -716,7 +716,7 @@ static int tegra_i2c_resume(struct platform_device *pdev)
>  #if defined(CONFIG_OF)
>  /* Match table for of_platform binding */
>  static const struct of_device_id tegra_i2c_of_match[] __devinitconst = {
> -	{ .compatible = "nvidia,tegra250-i2c", },
> +	{ .compatible = "nvidia,tegra20-i2c", },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, tegra_i2c_of_match);
> -- 
> 1.7.0.4
> 

  reply	other threads:[~2011-07-06  5:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 20:21 Stephen Warren
2011-07-06  5:39 ` Grant Likely [this message]
2011-07-13 17:59   ` Stephen Warren
2011-07-13 23:33     ` Grant Likely
2011-07-14 18:09       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706053941.GE9978@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=ben-linux@fluff.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=khali@linux-fr.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®