From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 3/3] Staging: comedi: fix warning: line over 80 characters issue in usbduxfast.c
Date: Wed, 6 Jul 2011 11:43:06 +0300 [thread overview]
Message-ID: <20110706084306.GG18655@shale.localdomain> (raw)
In-Reply-To: <1309940810-2381-1-git-send-email-ravishankarkm32@gmail.com>
On Wed, Jul 06, 2011 at 01:56:50PM +0530, Ravishankar wrote:
> - ret = request_firmware_nowait(THIS_MODULE,
> - FW_ACTION_HOTPLUG,
> - "usbduxfast_firmware.bin",
> - &udev->dev,
> - GFP_KERNEL,
> - usbduxfastsub + index,
> - usbduxfast_firmware_request_complete_handler);
> + ret =
> + request_firmware_nowait(THIS_MODULE,
> + FW_ACTION_HOTPLUG,
> + "usbduxfast_firmware.bin",
> + &udev->dev,
> + GFP_KERNEL,
> + usbduxfastsub + index,
> + usbduxfast_firmware_request_complete_handler);
> +
No. Don't do this. The "usbduxfast_firmware_request_complete_handler"
variable name is too long. Rename it something shorter.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-06 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi: fix warning line over 80 character issues in usbduxfast.c>
2011-07-06 8:26 ` Ravishankar
2011-07-06 8:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706084306.GG18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®