From: Anisse Astier <anisse@astier.eu>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>,
Thomas Renninger <trenn@suse.de>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform-drivers-x86: msi-wmi: add missing sparse_keymap_free in msi_wmi_init error path
Date: Wed, 6 Jul 2011 10:31:16 +0200 [thread overview]
Message-ID: <20110706103116.1949d632@destiny.ordissimo> (raw)
In-Reply-To: <1309921520.26847.3.camel@phoenix>
On Wed, 06 Jul 2011 11:05:20 +0800, Axel Lin <axel.lin@gmail.com> wrote :
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/msi-wmi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index c832e33..6f40bf2 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -272,6 +272,7 @@ static int __init msi_wmi_init(void)
> err_free_backlight:
> backlight_device_unregister(backlight);
> err_free_input:
> + sparse_keymap_free(msi_wmi_input_dev);
> input_unregister_device(msi_wmi_input_dev);
Nice catch ! Maybe doing the init in two different functions wasn't the
best for error handling.
Acked-by: Anisse Astier <anisse@astier.eu>
PS: It might already have been asked, but what's your secret Axel ? Do
you use static/dynamic analysis tools ? Which ones ?
next prev parent reply other threads:[~2011-07-06 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 3:05 Axel Lin
2011-07-06 8:31 ` Anisse Astier [this message]
2011-07-06 8:45 ` Axel Lin
2011-07-06 20:04 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706103116.1949d632@destiny.ordissimo \
--to=anisse@astier.eu \
--cc=axel.lin@gmail.com \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome