mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: balbi@ti.com, Alan Stern <stern@rowland.harvard.edu>,
	Partha Basak <p-basak2@ti.com>,
	Keshava Munegowda <keshava_mgowda@ti.com>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, Anand Gadiyar <gadiyar@ti.com>,
	sameo@linux.intel.com, parthab@india.ti.com, tony@atomide.com,
	Benoit Cousson <b-cousson@ti.com>,
	paul@pwsan.com, johnstul@us.ibm.com,
	Vishwanath Sripathy <vishwanath.bs@ti.com>
Subject: Re: [PATCH 6/6 v2] arm: omap: usb: global Suspend and resume support of ehci and ohci
Date: Thu, 7 Jul 2011 01:17:39 +0300	[thread overview]
Message-ID: <20110706221738.GA823@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <87sjqji5br.fsf@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Hi,

On Wed, Jul 06, 2011 at 12:20:40PM -0700, Kevin Hilman wrote:
> >> +	if ((od->flags & OMAP_DEVICE_SUSPENDED) &&
> >> +	    (od->_state == OMAP_DEVICE_STATE_IDLE))
> >> +		omap_device_enable(pdev);
> >> +	
> >> +	return pm_generic_resume(dev);
> >> +}
> >> +
> >>  static struct dev_power_domain omap_device_power_domain = {
> >>  	.ops = {
> >>  		.runtime_suspend = _od_runtime_suspend,
> >>  		.runtime_idle = _od_runtime_idle,
> >>  		.runtime_resume = _od_runtime_resume,
> >>  		USE_PLATFORM_PM_SLEEP_OPS
> >> +		.suspend = _od_suspend,
> >> +		.resume = _od_resume,
> >>  	}
> >>  };
> >
> > it all depends on when are you planning to get this patch upstream. I'm
> > considering getting some PM working on USB host and remove the
> > pm_runtime calls from system suspend/resume either during -rc or next
> > merge window.
> 
> Well, IMO it's way too late for this kind of change for -rc, so I'm
> considering it for the upcoming merge window.

yes, that's true. Who should take the hwmod patches btw ? I'm still
wondering if we should patch hwmod data first and push the _correct_ PM
part on 3.2.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-07-06 22:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 18:54 [PATCH 0/6 V2] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers Keshava Munegowda
2011-07-01 18:54 ` [PATCH 1/6 v2] arm: omap: usb: ehci and ohci hwmod structures for omap4 Keshava Munegowda
2011-07-01 18:54   ` [PATCH 2/6 v2] arm: omap: usb: ehci and ohci hwmod structures for omap3 Keshava Munegowda
2011-07-01 18:54     ` [PATCH 3/6 v2] arm: omap: usb: register hwmods of usbhs Keshava Munegowda
2011-07-01 18:54       ` [PATCH 4/6 v2] arm: omap: usb: device name change for the clk names " Keshava Munegowda
2011-07-01 18:54         ` [PATCH 5/6 v2] arm: omap: usb: Runtime PM support Keshava Munegowda
2011-07-01 18:54           ` [PATCH 6/6 v2] arm: omap: usb: global Suspend and resume support of ehci and ohci Keshava Munegowda
2011-07-01 19:06             ` Alan Stern
2011-07-04  5:06               ` Partha Basak
2011-07-04  8:25                 ` Felipe Balbi
2011-07-04  9:26                   ` Partha Basak
2011-07-04  9:30                     ` Felipe Balbi
2011-07-04 11:01                       ` Partha Basak
2011-07-04 16:01                       ` Alan Stern
2011-07-05 12:52                         ` Felipe Balbi
2011-07-05 14:17                           ` Alan Stern
2011-07-05 15:53                             ` Felipe Balbi
2011-07-05 16:28                               ` Alan Stern
2011-07-04 15:50                 ` Alan Stern
2011-07-05 14:00                   ` Partha Basak
2011-07-05 14:22                     ` Alan Stern
2011-07-05 17:37                       ` Kevin Hilman
2011-07-06 17:54                         ` Felipe Balbi
2011-07-06 19:20                           ` Kevin Hilman
2011-07-06 22:17                             ` Felipe Balbi [this message]
2011-07-07  4:53                               ` Partha Basak
2011-07-07  7:28                                 ` Felipe Balbi
2011-07-07 10:29   ` [PATCH 1/6 v2] arm: omap: usb: ehci and ohci hwmod structures for omap4 Felipe Balbi
2011-07-07 15:57     ` Kevin Hilman
2011-07-04 17:25 ` [PATCH 0/6 V2] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706221738.GA823@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=b-cousson@ti.com \
    --cc=gadiyar@ti.com \
    --cc=johnstul@us.ibm.com \
    --cc=keshava_mgowda@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p-basak2@ti.com \
    --cc=parthab@india.ti.com \
    --cc=paul@pwsan.com \
    --cc=sameo@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®