From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Hugh Dickins <hughd@chromium.org>, Olaf Hering <olaf@aepfle.de>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic, vt: do not force oops output when panic_timeout < 0
Date: Thu, 7 Jul 2011 08:53:41 +0100 [thread overview]
Message-ID: <20110707085341.200a3c2b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110622223039.GA13916@google.com>
> a serial port. When I disabled the serial out, my machine started to
> get wedged on a panic. I guess screen_unblank was in bust_spinlocks
> for a reason. It probably bust some spin_locks somewhere.
No something else is wrong here. The console panic should be reliably
breaking the locks but a quick test of taking the console lock and BUG()
on a current kernel shows something has broken this.
> Below is a replacement for this patch which calls screen_unblank but
> does not force output when the panic timeout is negative (no wait).
The on screen console is not always just a vt, and some people log remote
management console output so we really really don't want to do this.
Instead the bug in the lock busting needs fixing. To start with it will
be hiding a ton of other oopses/bugs as hangs.
Alan
next prev parent reply other threads:[~2011-07-07 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 23:22 [PATCH 1/2] panic: panic=-1 for immediate reboot Mandeep Singh Baines
2011-06-20 23:22 ` [PATCH 2/2] panic: do not unblank_screen when panic_timeout < 0 Mandeep Singh Baines
2011-06-22 22:30 ` [PATCH] panic, vt: do not force oops output " Mandeep Singh Baines
2011-07-06 23:33 ` Andrew Morton
2011-07-15 22:57 ` Mandeep Singh Baines
2011-07-07 7:53 ` Alan Cox [this message]
2011-07-15 21:39 ` Mandeep Singh Baines
2011-07-15 23:17 ` Alan Cox
2011-06-22 9:39 ` [PATCH 1/2] panic: panic=-1 for immediate reboot Olaf Hering
2011-06-22 22:17 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707085341.200a3c2b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=airlied@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@chromium.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=olaf@aepfle.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®