mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-usb@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.de>,
	Clemens Ladisch <clemens@ladisch.de>,
	florian@mickler.org, pedrib@gmail.com,
	William Light <wrl@illest.net>, Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Allocating buffers for USB transfers (again)
Date: Thu, 7 Jul 2011 14:33:42 +0200	[thread overview]
Message-ID: <201107071433.42081.oliver@neukum.org> (raw)
In-Reply-To: <CACTFLANCYMXH=z+NxEF0aqpMGZp21Q16_uB=J3rndM3pW74qeA@mail.gmail.com>

Am Donnerstag, 7. Juli 2011, 13:53:46 schrieb Daniel Mack:
> Takashi recently posted a patch to the bugzilla entry which uses a
> different approach: it introduces a function to determine suitable GFP
> flags for USB devices, and passes __DMA32 to kmalloc() eventually.
> However, using this flags directly with the SLUB allocator is illegal
> and causes a BUG() in mm/slub.c, cache_grow().
> 
> The question now is how to proceed. I see three possible ways.
> 
> 1. Find a way to allocate 32bit-aware memory with kmalloc(), following
> Takashi's idea

That is not really a good idea, because many drivers have to deal with buffers
another subsystem has allocated.

> 2. Find out exactly why these machines fail to install bounce buffers
> or set up their IOMMU correctly

This is still the correct approach. Given the cause this cannot be a problem
only for audio. We need the root cause.

> 3. re-activate the currently disabled functions
> usb_buffer_{map,unmap,sync} functions and let the USB stack do the
> memory mapping

The USB stack does call the DMA mapping operations.

	Regards
		Oliver

PS:  Do you still see this if you enable 64bit DMA for EHCI?

  parent reply	other threads:[~2011-07-07 12:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 11:53 Daniel Mack
2011-07-07 12:14 ` Clemens Ladisch
2011-07-07 12:29   ` Daniel Mack
2011-07-07 12:33 ` Oliver Neukum [this message]
2011-07-07 12:38   ` Daniel Mack
2011-07-07 13:08     ` Oliver Neukum
2011-07-08 15:13       ` Daniel Mack
2011-07-07 15:06     ` Alan Stern
2011-07-07 15:16     ` Florian Mickler
2011-08-10  7:51       ` Daniel Mack
2011-08-10 14:32         ` Alan Stern
2011-08-10 15:33           ` Daniel Mack
2011-08-10 18:06             ` Takashi Iwai
2011-08-10 23:15             ` Sarah Sharp
2011-08-11  0:57               ` Daniel Mack
2011-08-11 16:45                 ` Sarah Sharp
2011-08-11 17:27                   ` Daniel Mack
2011-08-11 18:05                     ` Sarah Sharp
2011-08-11 21:39                       ` Daniel Mack
2011-08-11 23:29                         ` Matěj Laitl
2011-08-11 23:40                           ` Daniel Mack
2011-08-11 23:50                             ` Matěj Laitl
2011-08-12  1:28                               ` Daniel Mack
2011-08-12  4:46                                 ` Sarah Sharp
2011-08-12  9:55                                   ` Daniel Mack
2011-08-11  3:22               ` Andiry Xu
2011-08-11 14:36                 ` Alan Stern
2011-07-07 13:53 ` Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107071433.42081.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=florian@mickler.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pedrib@gmail.com \
    --cc=tiwai@suse.de \
    --cc=wrl@illest.net \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®