mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Frederick van der Wyck <fvanderwyck@gmail.com>
Cc: mjg59@srcf.ucam.org, gregkh@suse.de,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Platform: Samsung Q10 backlight driver
Date: Thu, 7 Jul 2011 07:50:36 -0700	[thread overview]
Message-ID: <20110707145036.GK7658@core.coreip.homeip.net> (raw)
In-Reply-To: <20110704214357.GA17428@ntl>

Hi Frederick,

On Mon, Jul 04, 2011 at 10:43:57PM +0100, Frederick van der Wyck wrote:
>  
> +config SAMSUNG_Q10
> +	tristate "Samsung Q10 Extras"
> +	select BACKLIGHT_CLASS_DEVICE

Since the driver will not function without full i8042 code being present
I think you should add 'depends on SERIO_I8042' even though it compiles
without it being enabled.

Thanks.

-- 
Dmitry

  reply	other threads:[~2011-07-07 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 21:43 Frederick van der Wyck
2011-07-07 14:50 ` Dmitry Torokhov [this message]
2011-07-07 21:05   ` Frederick van der Wyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707145036.GK7658@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=fvanderwyck@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®