From: Dan Carpenter <error27@gmail.com>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Matt Mooney <mfm@muteddisk.com>, Max Vozeler <max@hinterhof.net>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
usbip-devel@lists.sourceforge.net, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] usbip: only dump valid port status
Date: Thu, 7 Jul 2011 22:28:57 +0300 [thread overview]
Message-ID: <20110707192857.GQ18655@shale.localdomain> (raw)
In-Reply-To: <4DF68151.4080109@freemail.hu>
On Mon, Jun 13, 2011 at 11:29:53PM +0200, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> The wIndex parameter of vhci_hub_control() is always zero when the
> request type is GetHubDescriptor, see drivers/usb/core/hub.c::get_hub_descriptor()
> and Universal Serial Bus Specification revision 2.0 (April 27, 2000) Section
> 11.24.2.5 "Get Hub Descriptor". This means the variable rhport will not contain
> any useful index. Only use valid rhport values.
>
Is it possible for wValue to be zero if the request type is is
SetPortFeature or ClearPortFeature? If so then we should probably
add some more checks to handle that.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-07 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 21:29 Németh Márton
2011-06-13 21:42 ` Joe Perches
2011-06-13 21:47 ` Németh Márton
2011-06-13 22:23 ` Joe Perches
2011-06-14 4:55 ` Németh Márton
2011-07-07 19:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707192857.GQ18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=max@hinterhof.net \
--cc=mfm@muteddisk.com \
--cc=nm127@freemail.hu \
--cc=sarah.a.sharp@linux.intel.com \
--cc=usbip-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®