From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: gma500: Mask out bits not part of the page table base address
Date: Thu, 7 Jul 2011 23:15:16 +0100 [thread overview]
Message-ID: <20110707231516.66cb90be@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110707220621.GA6922@patrik-macbook>
On Fri, 8 Jul 2011 00:06:21 +0200
Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote:
> Otherwise we can't ioremap the gtt and the screen gets garbled.
>
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> ---
>
> diff --git a/drivers/staging/gma500/gtt.c b/drivers/staging/gma500/gtt.c
> index 28f2261..78dd01b 100644
> --- a/drivers/staging/gma500/gtt.c
> +++ b/drivers/staging/gma500/gtt.c
> @@ -397,7 +397,7 @@ int psb_gtt_init(struct drm_device *dev, int resume)
> /* The root resource we allocate address space from */
> dev_priv->gtt_initialized = 1;
>
> - pg->gtt_phys_start = dev_priv->pge_ctl;
> + pg->gtt_phys_start = dev_priv->pge_ctl & PAGE_MASK;
Umm yes I suppose if its already been enabled that'll be slightly
important
Acked-by: Alan Cox <alan@linux.intel.com>
next prev parent reply other threads:[~2011-07-07 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 22:06 Patrik Jakobsson
2011-07-07 22:15 ` Alan Cox [this message]
2011-07-07 22:43 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707231516.66cb90be@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®