From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262Ab1GHJgP (ORCPT ); Fri, 8 Jul 2011 05:36:15 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:42166 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815Ab1GHJgN (ORCPT ); Fri, 8 Jul 2011 05:36:13 -0400 Date: Fri, 8 Jul 2011 10:35:42 +0100 From: Russell King - ARM Linux To: Heechul Yun Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, saeed.bishara@gmail.com Subject: Re: [PATCHv2] remove unnecessary cache flush on v6 copypage Message-ID: <20110708093542.GA4812@n2100.arm.linux.org.uk> References: <20110707143019.GA16819@heechul-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110707143019.GA16819@heechul-desktop> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2011 at 09:30:19AM -0500, Heechul Yun wrote: > > ARM: mm: remove unnecessary cache flush on v6 copypage > > Originally introduced to maintain coherency between icache and dcache > in v6 nonaliasing mode. This is now handled by __sync_icache_dcache since > c0177800, therefore unneceary in this function. > > Signed-off-by: Heechul Yun > Acked-by: Catalin Marinas > -- > arch/arm/mm/copypage-v6.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mm/copypage-v6.c b/arch/arm/mm/copypage-v6.c > index bdba6c6..63cca00 100644 > --- a/arch/arm/mm/copypage-v6.c > +++ b/arch/arm/mm/copypage-v6.c > @@ -41,7 +41,6 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to, > kfrom = kmap_atomic(from, KM_USER0); > kto = kmap_atomic(to, KM_USER1); > copy_page(kto, kfrom); > - __cpuc_flush_dcache_area(kto, PAGE_SIZE); > kunmap_atomic(kto, KM_USER1); > kunmap_atomic(kfrom, KM_USER0); > } The above patch is fine (it has tabs preserved) but the version in the patch system has spaces instead (each space character has been replaced with a '.') and so doesn't apply: $ pdb getpatch 6995/1 |tr ' ' '.' Patch:.6995/1:.mm:.remove.unnecessary.cache.flush.on.v6.copypage From:.Heechul.Yun ------------------------------------------------------------------------------- .arch/arm/mm/copypage-v6.c.|....1.- .1.file.changed,.1.deletion(-) ------------------------------------------------------------------------------- diff.--git.a/arch/arm/mm/copypage-v6.c.b/arch/arm/mm/copypage-v6.c index.bdba6c6..63cca00.100644 ---.a/arch/arm/mm/copypage-v6.c +++.b/arch/arm/mm/copypage-v6.c @@.-41,7.+41,6.@@.static.void.v6_copy_user_highpage_nonaliasing(struct.page.*to,........kfrom.=.kmap_atomic(from,.KM_USER0); ........kto.=.kmap_atomic(to,.KM_USER1); ........copy_page(kto,.kfrom); -.......__cpuc_flush_dcache_area(kto,.PAGE_SIZE); ........kunmap_atomic(kto,.KM_USER1); ........kunmap_atomic(kfrom,.KM_USER0); .}