From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Ken O'Brien" <kernel@kenobrien.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: Fix style error in Macros
Date: Fri, 8 Jul 2011 17:06:50 +0400 [thread overview]
Message-ID: <20110708130649.GA29056@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1306691592-29453-1-git-send-email-kernel@kenobrien.org>
On Sun, May 29, 2011 at 06:53:12PM +0100, Ken O'Brien wrote:
> Two Macros in the changed file contained complex expressions which were not
> enclosed by parentheses.
>
> Signed-off-by: Ken O'Brien <kernel@kenobrien.org>
> ---
Appled, thanks.
> drivers/power/apm_power.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/power/apm_power.c b/drivers/power/apm_power.c
> index dc628cb..8a612de 100644
> --- a/drivers/power/apm_power.c
> +++ b/drivers/power/apm_power.c
> @@ -14,11 +14,11 @@
> #include <linux/apm-emulation.h>
>
>
> -#define PSY_PROP(psy, prop, val) psy->get_property(psy, \
> - POWER_SUPPLY_PROP_##prop, val)
> +#define PSY_PROP(psy, prop, val) (psy->get_property(psy, \
> + POWER_SUPPLY_PROP_##prop, val))
>
> -#define _MPSY_PROP(prop, val) main_battery->get_property(main_battery, \
> - prop, val)
> +#define _MPSY_PROP(prop, val) (main_battery->get_property(main_battery, \
> + prop, val))
>
> #define MPSY_PROP(prop, val) _MPSY_PROP(POWER_SUPPLY_PROP_##prop, val)
parent reply other threads:[~2011-07-08 13:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1306691592-29453-1-git-send-email-kernel@kenobrien.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708130649.GA29056@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=kernel@kenobrien.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®