From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 9/9] Staging: comedi: fix printk issue in pcmmio.c
Date: Sat, 9 Jul 2011 11:32:41 +0300 [thread overview]
Message-ID: <20110709083241.GD18655@shale.localdomain> (raw)
In-Reply-To: <1310192700-14603-1-git-send-email-ravishankarkm32@gmail.com>
On Sat, Jul 09, 2011 at 11:55:00AM +0530, Ravishankar wrote:
> @@ -663,7 +663,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
> }
> #ifdef DAMMIT_ITS_BROKEN
> /* DEBUG */
> - printk("data_out_byte %02x\n", (unsigned)byte);
> + printk(KERN_DEBUG "data_out_byte %02x\n", (unsigned) byte);
> #endif
The indenting was correct in the original.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-09 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 1/2]Staging: comedi: fix warning: printk()issue in pcmmio.c>
2011-07-09 6:25 ` Ravishankar
2011-07-09 8:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110709083241.GD18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®