From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976Ab1GKJ5M (ORCPT ); Mon, 11 Jul 2011 05:57:12 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:54006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317Ab1GKJ5L (ORCPT ); Mon, 11 Jul 2011 05:57:11 -0400 Date: Mon, 11 Jul 2011 05:57:08 -0400 From: Christoph Hellwig To: Dave Chinner Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 02/14] vmscan: add shrink_slab tracepoints Message-ID: <20110711095708.GB19354@infradead.org> References: <1310098486-6453-1-git-send-email-david@fromorbit.com> <1310098486-6453-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1310098486-6453-3-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2011 at 02:14:34PM +1000, Dave Chinner wrote: > From: Dave Chinner > > ??t is impossible to understand what the shrinkers are actually doing > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. > > Signed-off-by: Dave Chinner Looks good. But wouldn't it be a good idea to give the shrinkers names so that we can pretty print those in the trace event?