From: Randy Dunlap <rdunlap@xenotime.net>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Jesper Juhl <jj@chaosbits.net>,
Arnaud Lacombe <lacombar@gmail.com>,
Pekka Enberg <penberg@kernel.org>,
Am?rico Wang <xiyou.wangcong@gmail.com>,
Raghavendra D Prabhu <rprabhu@wnohang.net>,
linux-kbuild@vger.kernel.org, Nir Tzachar <nir.tzachar@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Avoid Wunused-but-set warning
Date: Mon, 11 Jul 2011 10:11:34 -0700 [thread overview]
Message-ID: <20110711101134.613d88ee.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110711050951.GA22699@sirena.org.uk>
On Mon, 11 Jul 2011 06:09:52 +0100 Mark Brown wrote:
> On Sun, Jul 10, 2011 at 04:53:33PM -0700, Randy Dunlap wrote:
>
> > But do as you like. Which parts of SubmittingPatches do you think
> > support your interpretation?
>
> > and should we have this line:
> > Acked-by: is not as formal as Signed-off-by:.
> > changed to:
> > Acked-by: is not as formal as Signed-off-by: or Reviewed-by:.
> > e.g.?
>
> Current practice seems to be that Acked-by is used instead of
> Reviewed-by - the latter is comparatively rare.
ISTM that more education and encouragement are needed about Reviewed-by:.
(Patch Review is a possible kernel summit topic.)
and that SubmittingPatches should be updated since we generally refer people
to that file and not to Documentation/development-process/
Samples from my partial mailing list archives:
linux-pci mailing list: Acked-by: 93 Reviewed-by: 81
linux-mm mailing list: Acked-by: 2104 Reviewed-by: 1344
netdev mailing list: Acked-by: 1366 Reviewed-by: 659
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-07-11 17:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 16:24 Raghavendra D Prabhu
2011-07-10 16:16 ` Américo Wang
2011-07-10 16:24 ` Arnaud Lacombe
2011-07-10 16:28 ` Pekka Enberg
2011-07-10 16:49 ` Arnaud Lacombe
2011-07-10 16:51 ` Américo Wang
2011-07-10 17:22 ` Arnaud Lacombe
2011-07-10 17:24 ` Pekka Enberg
2011-07-10 18:02 ` Randy Dunlap
2011-07-10 22:56 ` Jesper Juhl
2011-07-10 23:07 ` Randy Dunlap
2011-07-10 23:21 ` Jesper Juhl
2011-07-10 23:53 ` Randy Dunlap
2011-07-11 5:09 ` Mark Brown
2011-07-11 17:11 ` Randy Dunlap [this message]
2011-07-11 22:42 ` Mark Brown
2011-07-13 1:15 ` Américo Wang
2011-07-13 2:21 ` Arnaud Lacombe
2011-07-13 12:16 ` Pekka Enberg
2011-07-11 20:32 ` Jesper Juhl
2011-07-11 5:55 ` Pekka Enberg
2011-07-11 20:37 ` Jesper Juhl
2011-07-13 0:35 ` Valdis.Kletnieks
2011-07-13 0:55 ` Randy Dunlap
2011-07-10 16:49 ` Américo Wang
2011-07-13 11:39 ` Michal Marek
2011-07-18 19:00 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711101134.613d88ee.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jj@chaosbits.net \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.tzachar@gmail.com \
--cc=penberg@kernel.org \
--cc=rprabhu@wnohang.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®