From: Matt Fleming <matt.fleming@linux.intel.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signals: sys_ssetmask/sys_rt_sigsuspend should use set_current_blocked()
Date: Tue, 12 Jul 2011 19:17:30 +0100 [thread overview]
Message-ID: <20110712191730.3fb554a4@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20110711160102.GA14797@redhat.com>
On Mon, 11 Jul 2011 18:01:02 +0200
Oleg Nesterov <oleg@redhat.com> wrote:
> sys_ssetmask(), sys_rt_sigsuspend() and compat_sys_rt_sigsuspend()
> change ->blocked directly. This is not correct, see the changelog in
> e6fa16ab "signal: sigprocmask() should do retarget_shared_pending()"
>
> Change them to use set_current_blocked().
>
> Another change is that now we are doing ->saved_sigmask = ->blocked
> lockless, it doesn't make any sense to do this under ->siglock.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
next prev parent reply other threads:[~2011-07-12 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 16:01 Oleg Nesterov
2011-07-12 18:17 ` Matt Fleming [this message]
2011-07-13 12:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712191730.3fb554a4@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®