From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Samuli Konttila <samuli.konttila@aavamobile.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alan Cox <alan@linux.intel.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: cy8ctmg110_ts - set reset_pin and irq_pin from platform data
Date: Wed, 13 Jul 2011 14:20:55 +0100 [thread overview]
Message-ID: <20110713142055.3036c62d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1310562419.5753.2.camel@phoenix>
On Wed, 13 Jul 2011 21:06:59 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> The implementation in cy8ctmg110_probe() does not properly set reset_pin
> and irq_pin from platform data. Let's fix it.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Current implementation returns -ENODEV if no pdata available.
> But it does not use the information from pdata.
> I think currently the driver does not work because both ts->reset_pin and ts->irq_pin are 0, then gpio_request with ts->irq_pin will fail.
>
> Just found this bug while reading the code.
> I don't have this hardware. I appreciate if someone can test it.
Looks right, but I'm likewise unable to test it as I no longer have
access to a device using it.
Alan
prev parent reply other threads:[~2011-07-13 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 13:06 Axel Lin
2011-07-13 13:20 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713142055.3036c62d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuli.konttila@aavamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®