From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 1/3] Staging: comedi: fix warning issue in daqboard2000.c
Date: Thu, 14 Jul 2011 10:59:50 +0300 [thread overview]
Message-ID: <20110714075950.GS18655@shale.localdomain> (raw)
In-Reply-To: <1310623333-16176-1-git-send-email-ravishankarkm32@gmail.com>
On Thu, Jul 14, 2011 at 11:32:13AM +0530, Ravishankar wrote:
> 2. The initialization done so far is:
> - a. program the FPGA (windows code sans a lot of error messages)
> + a.program the FPGA(windows code sans a lot of error messages)
^
Space needed here.
>
> - Word0:
> - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> - ! | | | ! | | | ! | | | ! | | | !
> - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> + Word0:
> + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> + !|||!|||!|||!|||!
> + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
No. The original comment is a diagram and you have destroyed it
completely.
You are writing all these patches to do the minimum needed to make
check patch happy. Check patch is not a human being. Do not write
code to please check patch, because it feels no sadness or happiness.
You have made yourself into a servant of a shell script. Have some
dignity.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-14 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 1/3]Staging : comedi: fix indentation warning issue in daqboard2000.c>
2011-07-14 6:02 ` Ravishankar
2011-07-14 7:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714075950.GS18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®