From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755156Ab1GNNoe (ORCPT ); Thu, 14 Jul 2011 09:44:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:43748 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754882Ab1GNNod (ORCPT ); Thu, 14 Jul 2011 09:44:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,529,1304319600"; d="scan'208";a="27914214" Date: Thu, 14 Jul 2011 14:44:20 +0100 From: Matt Fleming To: Oleg Nesterov Cc: Andrew Morton , Dave Hansen , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org Subject: Re: [PATCH] acct_arg_size: ptl is no longer needed for add_mm_counter() Message-ID: <20110714144420.38c3d539@mfleming-mobl1.ger.corp.intel.com> In-Reply-To: <20110713193935.GA18026@redhat.com> References: <20110713193935.GA18026@redhat.com> X-Mailer: Claws Mail 3.7.8cvs52 (GTK+ 2.22.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2011 21:39:35 +0200 Oleg Nesterov wrote: > acct_arg_size() takes ->page_table_lock around add_mm_counter() > if !SPLIT_RSS_COUNTING. This is no needed after 172703b0 > "mm: delete non-atomic mm counter implementation". > > Signed-off-by: Oleg Nesterov Oops, good catch. Thanks! Reviewed-by: Matt Fleming