From: Grant Likely <grant.likely@secretlab.ca>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, David Dajun Chen <dchen@diasemi.com>
Subject: Re: [PATCH] gpio: da9052: remove a redundant assignment for gpio->da9052
Date: Thu, 14 Jul 2011 20:53:32 -0600 [thread overview]
Message-ID: <20110715025332.GM2927@ponder.secretlab.ca> (raw)
In-Reply-To: <1310345618.2316.0.camel@phoenix>
On Mon, Jul 11, 2011 at 08:53:38AM +0800, Axel Lin wrote:
> We just set it twice in da9052_gpio_probe.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-da9052.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c
> index c23761f..038f5eb 100644
> --- a/drivers/gpio/gpio-da9052.c
> +++ b/drivers/gpio/gpio-da9052.c
> @@ -219,7 +219,6 @@ static int __devinit da9052_gpio_probe(struct platform_device *pdev)
> gpio->da9052 = dev_get_drvdata(pdev->dev.parent);
> pdata = gpio->da9052->dev->platform_data;
>
> - gpio->da9052 = dev_get_drvdata(pdev->dev.parent);
> gpio->gp = reference_gp;
> if (pdata && pdata->gpio_base)
> gpio->gp.base = pdata->gpio_base;
> --
> 1.7.4.1
>
>
>
prev parent reply other threads:[~2011-07-15 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 0:53 Axel Lin
2011-07-15 2:53 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715025332.GM2927@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=axel.lin@gmail.com \
--cc=dchen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®