From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610Ab1GRPV0 (ORCPT ); Mon, 18 Jul 2011 11:21:26 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:56051 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357Ab1GRPVZ (ORCPT ); Mon, 18 Jul 2011 11:21:25 -0400 Date: Mon, 18 Jul 2011 11:21:18 -0400 From: Christoph Hellwig To: Randy Dunlap Cc: Stephen Rothwell , linux-mm@kvack.org, linux-next@vger.kernel.org, LKML , akpm , viro@zeniv.linux.org.uk Subject: Re: linux-next: Tree for July 18 (mm/truncate.c) Message-ID: <20110718152117.GA8844@infradead.org> References: <20110718203501.232bd176e83ff65f056366e6@canb.auug.org.au> <20110718081816.2106117e.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110718081816.2106117e.rdunlap@xenotime.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote: > On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote: > > > Hi all, > > mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' > > mm/truncate.c should be #include-ing for that function's > prototype, but that doesn't help when CONFIG_BLOCK is not enabled, > which is the case in this build failure. Oops. Two choices here: a) stub it out for non-blocks. b) move it out of directio.c so that it's always provided. I'd be fine with either one. Al, any preferences? > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org ---end quoted text---