mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: JiSheng Zhang <jszhang3@gmail.com>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] USB: xhci: fix OS want to own HC
Date: Mon, 18 Jul 2011 09:44:10 -0700	[thread overview]
Message-ID: <20110718164410.GA4879@xanatos> (raw)
In-Reply-To: <20110716110419.726be2b0@ustc>

On Sat, Jul 16, 2011 at 11:04:19AM +0800, JiSheng Zhang wrote:
> Software should set XHCI_HC_OS_OWNED bit to request ownership of xHC

Good catch!  I'll queue this up to my for-usb-linus branch and send it
out to Greg later today.

Greg, do you think it's too late to get this into 3.0?  Shall I just
add it to usb-next and mark it for stable?

Sarah Sharp

> Signed-off-by: JiSheng Zhang <jszhang3@gmail.com>
> ---
>  drivers/usb/host/pci-quirks.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index fd93061..1a73004 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -775,7 +775,7 @@ static void __devinit quirk_usb_handoff_xhci(struct pci_dev *pdev)
>  
>  	/* If the BIOS owns the HC, signal that the OS wants it, and wait */
>  	if (val & XHCI_HC_BIOS_OWNED) {
> -		writel(val & XHCI_HC_OS_OWNED, base + ext_cap_offset);
> +		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
>  
>  		/* Wait for 5 seconds with 10 microsecond polling interval */
>  		timeout = handshake(base + ext_cap_offset, XHCI_HC_BIOS_OWNED,
> -- 
> 1.7.5.4
> 

  reply	other threads:[~2011-07-18 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-16  3:04 JiSheng Zhang
2011-07-18 16:44 ` Sarah Sharp [this message]
2011-07-19  1:18   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110718164410.GA4879@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=jszhang3@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome