From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 1/2] Staging: comedi: fix printk() issue in adv_pci1710.c
Date: Mon, 18 Jul 2011 20:23:51 +0300 [thread overview]
Message-ID: <20110718172351.GC4010@shale.localdomain> (raw)
In-Reply-To: <1310996009-21674-1-git-send-email-ravishankarkm32@gmail.com>
On Mon, Jul 18, 2011 at 07:03:29PM +0530, Ravishankar wrote:
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -1396,14 +1396,14 @@ static int pci1710_attach(struct comedi_device *dev,
> int i;
> int board_index;
>
> - printk("comedi%d: adv_pci1710: ", dev->minor);
> + printk(KERN_INFO "comedi%d: adv_pci1710: ", dev->minor);
>
> opt_bus = it->options[0];
> opt_slot = it->options[1];
>
> ret = alloc_private(dev, sizeof(struct pci1710_private));
> if (ret < 0) {
> - printk(" - Allocation failed!\n");
> + printk(KERN_INFO " - Allocation failed!\n");
This is on the same line as the previous printk() so KERN_INFO isn't
correct.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-18 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi:fix printk() issue in adv_pci1710.c>
2011-07-18 13:33 ` Ravishankar
2011-07-18 17:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718172351.GC4010@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®