From: Dan Carpenter <error27@gmail.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Ravishankar <ravishankarkm32@gmail.com>,
devel@driverdev.osuosl.org, gregkh@suse.de,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c
Date: Tue, 19 Jul 2011 09:12:26 +0300 [thread overview]
Message-ID: <20110719061226.GF4010@shale.localdomain> (raw)
In-Reply-To: <4E251F1F.2080406@gmail.com>
On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote:
> This still isn't correct. The initial printk (KERN_INFO above) has
> no trailing newline. Here you are almost doing it correctly, except
> that you are adding an extra newline. This error message will look
> like this:
>
> comedi0: adv_pci1710:
> comedi0: adv_pci1710: Allocation failed
>
Actually kmalloc() prints an message with a stack trace on failure as
well so that would go in the middle, just before the first newline.
regards,
dan carpenter
next prev parent reply other threads:[~2011-07-19 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi: fix printk() issue in adv_pci1710.c>
2011-07-19 3:52 ` [PATCH 1/2 v2] " Ravishankar
2011-07-19 3:55 ` Joe Perches
2011-07-19 4:55 ` [PATCH 1/2 v3] " Ravishankar
2011-07-19 4:52 ` Joe Perches
2011-07-19 5:50 ` Ravishankar
2011-07-19 6:07 ` Ryan Mallon
2011-07-19 6:12 ` Dan Carpenter [this message]
2011-07-19 6:15 ` Ryan Mallon
2011-07-19 6:25 ` Dan Carpenter
2011-07-19 23:44 ` Ryan Mallon
[not found] <[PATCH]Staging: Comedi: fix printk issue in adv_pci1710.c>
2011-07-22 11:24 ` [PATCH 1/2 v3] Staging: comedi: fix printk " Ravishankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719061226.GF4010@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®