From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250Ab1GSG1y (ORCPT ); Tue, 19 Jul 2011 02:27:54 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:59085 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092Ab1GSG1x (ORCPT ); Tue, 19 Jul 2011 02:27:53 -0400 Date: Tue, 19 Jul 2011 09:25:59 +0300 From: Dan Carpenter To: Ryan Mallon Cc: Ravishankar , devel@driverdev.osuosl.org, gregkh@suse.de, linux-kernel@vger.kernel.org, Ravishankar Subject: Re: [PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c Message-ID: <20110719062559.GG4010@shale.localdomain> References: <1311054656-14207-1-git-send-email-ravishanakarkm32@gmail.com> <4E251F1F.2080406@gmail.com> <20110719061226.GF4010@shale.localdomain> <4E252117.4000500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E252117.4000500@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2011 at 04:15:51PM +1000, Ryan Mallon wrote: > On 19/07/11 16:12, Dan Carpenter wrote: > >On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote: > >>This still isn't correct. The initial printk (KERN_INFO above) has > >>no trailing newline. Here you are almost doing it correctly, except > >>that you are adding an extra newline. This error message will look > >>like this: > >> > >>comedi0: adv_pci1710: > >>comedi0: adv_pci1710: Allocation failed > >> > >Actually kmalloc() prints an message with a stack trace on failure as > >well so that would go in the middle, just before the first newline. > > > > Thanks. Didn't know that. Is that a KConfig option or by default? By default, unless you call kmalloc() with __GFP_NOWARN. The warning is in warn_alloc_failed(). regards, dan carpenter