From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Grant Likely <grant.likely@secretlab.ca>,
Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: Re: [PATCH] gpio/mxc/mxs: fix build error introduced by the reanming of irq_gc_ack()
Date: Tue, 19 Jul 2011 17:23:23 +0200 [thread overview]
Message-ID: <20110719152323.GA6628@pengutronix.de> (raw)
In-Reply-To: <20110719125917.GK3838@S2100-06.ap.freescale.net>
Hello Shawn,
> > > ct = gc->chip_types;
> > >- ct->chip.irq_ack = irq_gc_ack,
> > >+ ct->chip.irq_ack = irq_gc_ack_set_bit,
> >
> > There should be semicolon rathern than comma at the end.
> >
> Thanks, Sergei. I'm pretty surprised that gcc did not help me there.
> > > ct->chip.irq_mask = irq_gc_mask_clr_bit;
That's because using a comma is valid C, too.
It just assigns ct->chip.irq_ack as a side effect of the
expression
ct->chip.irq_ack = irq_gc_ack_set_bit, ct->chip.irq_unmask = irq_gc_mask_set_bit;
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-07-19 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 3:34 Shawn Guo
2011-07-19 12:38 ` Sergei Shtylyov
2011-07-19 12:59 ` Shawn Guo
2011-07-19 15:23 ` Uwe Kleine-König [this message]
2011-07-19 13:16 ` [PATCH v2] gpio/mxc/mxs: fix build error introduced by the irq_gc_ack() renaming Shawn Guo
2011-07-19 19:10 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719152323.GA6628@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®