From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Greg KH <greg@kroah.com>, Grant Likely <grant@secretlab.ca>,
Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Samuel Oritz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] regmap: Add SPI bus support
Date: Tue, 19 Jul 2011 15:51:20 -0600 [thread overview]
Message-ID: <20110719215120.GS6848@ponder.secretlab.ca> (raw)
In-Reply-To: <1310983663-6404-3-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, Jul 18, 2011 at 07:07:42PM +0900, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Acked-by: Liam Girdwood <lrg@ti.com>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
One comment below, but otherwise:
Acked-by: Grant Likely <grant.likely@secretlab.ca>
on the whole series.
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index e509bac..c549632 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -61,6 +61,9 @@ struct regmap *regmap_init(struct device *dev,
> const struct regmap_config *config);
> struct regmap *regmap_init_i2c(struct device *dev,
> const struct regmap_config *config);
> +struct regmap *regmap_init_spi(struct device *dev,
> + const struct regmap_config *config);
> +
regmap_init_i2c/spi should take an i2c_client and spi_device pointer
respectively so it can be type checked.
> void regmap_exit(struct regmap *map);
> int regmap_write(struct regmap *map, unsigned int reg, unsigned int val);
> int regmap_raw_write(struct regmap *map, unsigned int reg,
> --
> 1.7.5.4
>
next prev parent reply other threads:[~2011-07-19 21:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 10:04 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-18 10:07 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-18 10:07 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
2011-07-18 10:07 ` [PATCH 3/4] regmap: Add SPI " Mark Brown
2011-07-19 21:51 ` Grant Likely [this message]
2011-07-20 10:33 ` Mark Brown
2011-07-18 10:07 ` [PATCH 4/4] regulator: Convert tps65023 to use regmap API Mark Brown
2011-07-18 10:38 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Takashi Iwai
2011-07-18 10:50 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-07-16 2:48 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-16 2:48 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-16 2:48 ` [PATCH 3/4] regmap: Add SPI bus support Mark Brown
2011-07-15 6:22 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-15 6:23 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-15 6:23 ` [PATCH 3/4] regmap: Add SPI bus support Mark Brown
2011-07-09 4:49 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-09 4:50 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-09 4:50 ` [PATCH 3/4] regmap: Add SPI bus support Mark Brown
2011-07-15 2:53 ` Grant Likely
2011-07-15 4:39 ` Mark Brown
2011-07-15 5:04 ` Grant Likely
2011-07-15 5:09 ` Mark Brown
2011-07-15 9:01 ` Jonathan Cameron
2011-07-15 18:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719215120.GS6848@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=grant@secretlab.ca \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®