mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: Build regressions/improvements in v3.0-rc7 (sound/isa/)
Date: Sun, 24 Jul 2011 12:26:24 -0700	[thread overview]
Message-ID: <20110724122624.324d10dc.rdunlap@xenotime.net> (raw)
In-Reply-To: <1310585610-434-1-git-send-email-geert@linux-m68k.org>

On Wed, 13 Jul 2011 21:33:30 +0200 Geert Uytterhoeven wrote:

>   + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_disable':  => 544
>   + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_pointer':  => 302
>   + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_program':  => 244
>   + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_pointer':  => 509
>   + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_program':  => 417
>   + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_disable':  => 177
>   + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_program':  => 79
>   + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_pointer':  => 619
>   + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_program':  => 591
>   + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_pointer':  => 456
>   + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_program':  => 276
>   + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_pointer':  => 425
>   + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_program':  => 172
>   + src/sound/isa/sscape.c: error: implicit declaration of function 'snd_dma_program':  => 481
>   + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_disable':  => 1695
>   + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_pointer':  => 1160
>   + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_program':  => 1025

All of these source files do #include <sound/core.h>,
but these missing/implicit functions are conditional:

#ifdef CONFIG_ISA_DMA_API
#define DMA_MODE_NO_ENABLE	0x0100

void snd_dma_program(unsigned long dma, unsigned long addr, unsigned int size, unsigned short mode);
void snd_dma_disable(unsigned long dma);
unsigned int snd_dma_pointer(unsigned long dma, unsigned int size);
#endif

so should these drivers all depend on ISA_DMA_API ?
or should only pieces of each driver depend on ISA_DMA_API ?


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-07-24 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 19:33 Build regressions/improvements in v3.0-rc7 Geert Uytterhoeven
2011-07-24 19:26 ` Randy Dunlap [this message]
2011-07-25  7:37   ` Build regressions/improvements in v3.0-rc7 (sound/isa/) Takashi Iwai
2011-07-25 16:10     ` Randy Dunlap
2011-07-27 19:13       ` Randy Dunlap
2011-07-28  1:17         ` Stephen Rothwell
2011-07-28  2:49           ` Arnaud Lacombe
2011-07-28 16:21           ` Randy Dunlap
2011-07-28 16:36             ` Arnaud Lacombe
2011-07-28 16:44               ` Randy Dunlap
2011-07-28 17:06                 ` Arnaud Lacombe
2011-07-28 18:11                   ` Takashi Iwai
2011-07-28 18:24                     ` Arnaud Lacombe
2011-07-28 18:58                       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110724122624.324d10dc.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®