From: Daniel Drake <dsd@laptop.org>
To: tglx@linutronix.de
To: mingo@redhat.com
To: hpa@zytor.com
To: x86@kernel.org
Cc: rdunlap@xenotime.net
Cc: linux-kernel@vger.kernel.org
Cc: dilinger@queued.net
Subject: [PATCH] x86, olpc: Fix dependency on POWER_SUPPLY
Date: Sun, 24 Jul 2011 18:33:21 +0100 (BST) [thread overview]
Message-ID: <20110724173321.747BC9D401C@zog.reactivated.net> (raw)
As reported by Randy Dunlap, CONFIG_POWER_SUPPLY=m caused a compile error:
arch/x86/built-in.o: In function `battery_status_changed':
olpc-xo15-sci.c:(.text+0x3acdd): undefined reference to `power_supply_get_by_name'
olpc-xo15-sci.c:(.text+0x3ad04): undefined reference to `power_supply_changed'
The SCI drivers, as bool, require POWER_SUPPLY to be builtin. Use
select to make that a hard requirement and avoid this build failure.
Signed-off-by: Daniel Drake <dsd@laptop.org>
---
arch/x86/Kconfig | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 8af5ba8..b198c01 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2089,7 +2089,8 @@ config OLPC_XO1_RTC
config OLPC_XO1_SCI
bool "OLPC XO-1 SCI extras"
- depends on OLPC && OLPC_XO1_PM && POWER_SUPPLY
+ depends on OLPC && OLPC_XO1_PM
+ select POWER_SUPPLY
select GPIO_CS5535
select MFD_CORE
---help---
@@ -2103,7 +2104,8 @@ config OLPC_XO1_SCI
config OLPC_XO15_SCI
bool "OLPC XO-1.5 SCI extras"
- depends on OLPC && ACPI && POWER_SUPPLY
+ depends on OLPC && ACPI
+ select POWER_SUPPLY
---help---
Add support for SCI-based features of the OLPC XO-1.5 laptop:
- EC-driven system wakeups
--
1.7.6
next reply other threads:[~2011-07-24 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 17:33 Daniel Drake [this message]
2011-07-24 17:36 ` Randy Dunlap
2011-07-24 18:15 ` Ingo Molnar
2011-07-24 18:19 ` Daniel Drake
2011-07-24 18:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110724173321.747BC9D401C@zog.reactivated.net \
--to=dsd@laptop.org \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®